Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSX shards. #565

Merged
merged 1 commit into from
Sep 29, 2018
Merged

Add OSX shards. #565

merged 1 commit into from
Sep 29, 2018

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Sep 29, 2018

Fixes #479

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Glad to see the use of YAML variables.

As a separate issue, we might want to consider adding tests for Python 3.7. Currently Travis doesn’t natively support it though, so it’s very hacky to get support and adds about 3 minutes to CI to download the interpreter every time. travis-ci/travis-ci#9815 Probably still worth it? Do we have any PEX users using Python 3.7 that we know of? Foursquare temporarily used it but had to roll back to 3.6 due to issues with installing on Linux.

@jsirois
Copy link
Member Author

jsirois commented Sep 29, 2018

I've filed #566 for 3.7 support. That will now be straightforward to add - and if I switch the linux shards to using pyenv, it will be at ~ no time cost since we're caching the pyenv already.

@jsirois jsirois merged commit 2325647 into pex-tool:master Sep 29, 2018
@jsirois jsirois deleted the issues/479 branch September 29, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants