Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -m and -c in interpreter mode. #563

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Sep 28, 2018

This emulates the behavior of the python interpreter as we already do for
- and .

Fixes #547

This emulates the behavior of the python interpreter as we already do for
`-` and <file>.

Fixes pex-tool#547
@jsirois
Copy link
Member Author

jsirois commented Sep 28, 2018

@fhoering if you're available for review, thanks in advance!

@jsirois jsirois requested a review from kwlzn September 28, 2018 20:40
Copy link

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have low context on this one, but it seems fine as long as you're sure it doesn't paint you into a corner with regard to supporting additional execution modes in the future.

@jsirois
Copy link
Member Author

jsirois commented Sep 28, 2018

Thanks Stu. I think we're good. Previously we supported 2 of exactly 4 execution modes of cpython:

$ pyyhon -h
usage: python [option] ... [-c cmd | -m mod | file | -] [arg] ...
...

@jsirois jsirois merged commit a381c4d into pex-tool:master Sep 28, 2018
@jsirois jsirois deleted the issues/547 branch September 28, 2018 22:18
@fhoering
Copy link
Contributor

fhoering commented Oct 1, 2018

I had a look. Perfect. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants