Fixup PEX.demote_bootstrap: fully unimport.
#554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only root 3rdparty packages copied into the bootstrap were unimported leaving subpackages in-place. This could lead to a mismatch in 3rdparty package API expectations when a re-imported 3rdparty root package from the user PEX sys.path was from a different version of the 3rdparty package. Fixes pex-tool#550
|
NB: The new test fails before the fix. |
|
@DrumMachineLearning, @zsimic & @zvezdan: if any of you all could try this out prior to release I'd be grateful. |
|
#555 tracks a hotfix release for this. |
Eric-Arellano
approved these changes
Sep 25, 2018
|
Thanks a bunch for the review Eric! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only root 3rdparty packages copied into the bootstrap were
unimported leaving subpackages in-place. This could lead to a mismatch
in 3rdparty package API expectations when a re-imported 3rdparty root
package from the user PEX sys.path was from a different version of the
3rdparty package.
Fixes #550