Introduce a controlled env for pex testing. #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this could be used as a stepping stone to containerized Travis CI, in the short term it helps me have a working test environment. The `pex.testing.ensure_python_interpreter` fails to install CPython 2.7.9, 2.7.10, etc. on Arch Linux atm.
|
N.B: This allows me to run |
Also set hash labels in key-value form for better readability using docker inspect.
kwlzn
approved these changes
Jun 15, 2018
dtox.sh
Outdated
|
|
||
| exec docker run \ | ||
| --tty \ | ||
| --rm \ |
There was a problem hiding this comment.
might this need a -i here too for e.g. pdb? or does --tty imply that?
There was a problem hiding this comment.
Yup, I had not thought about interactive tox commands. Added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this could be used as a stepping stone to containerized
Travis CI, in the short term it helps me have a working test
environment. The
pex.testing.ensure_python_interpreterfails toinstall CPython 2.7.9, 2.7.10, etc. on Arch Linux atm.