Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum setuptools version should be 20.3 #391

Merged
merged 1 commit into from
May 26, 2017

Conversation

cheister
Copy link
Contributor

@cheister cheister commented May 26, 2017

In #355 package.py was updated to assume that the Requirement class has the specifier attribute.

The specifier attribute wasn't added to the Requirement class until setuptools 20.3 pypa/setuptools@de4bdcf

The error when there is an older setuptools is

Exception message: Requirement instance has no attribute 'specifier'

Copy link
Contributor

@kwlzn kwlzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@kwlzn kwlzn merged commit 0d01ba8 into pex-tool:master May 26, 2017
@kwlzn kwlzn mentioned this pull request May 26, 2017
@cheister cheister deleted the minimum-setuptools branch May 26, 2017 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants