Fix --pip-log re-use.
#2570
Merged
Fix --pip-log re-use.
#2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when only 1 resolve target was specified, a `--pip-log` would be re-used which would append the current Pip log outout with the prior output. For a normal PEX build, this was potentially confusing, but for a `pex3 lock` command it could lead to errors since the log is used to generate the lock. Fixes pex-tool#2568
jsirois
commented
Oct 23, 2024
| lock = tmpdir.join("lock.json") | ||
| log = tmpdir.join("pip.log") | ||
| run_pex3( | ||
| "lock", "sync", "--lock", lock, "--pip-log", log, "ansicolors==1.1.8", "cowsay==6.0" |
There was a problem hiding this comment.
N.B.: This is the issue OP test, but with cowsay 6.0 instead of 6.1 so the Python 2.7 tests work.
benjyw
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when only 1 resolve target was specified, a
--pip-logwould be re-used which would append the current Pip log outout with the
prior output. For a normal PEX build, this was potentially confusing,
but for a
pex3 lockcommand it could lead to errors since the log isused to generate the lock.
Fixes #2568