Fix pex --only-binary X --lock ....
#2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since pex-tool#2346 which was released in Pex 2.1.161, using `--only-binary X` with a `--lock` would fail fast even if the lock itself was created with `--only-binary X`, which should be compatible. Fixes pex-tool#2432
huonw
approved these changes
Jun 22, 2024
| self._build_configuration = attr.evolve( | ||
| build_configuration, allow_wheels=False, allow_builds=True, prefer_older_binary=False | ||
| build_configuration, allow_builds=True, prefer_older_binary=False |
There was a problem hiding this comment.
I was initially confused why changes to VCSArtifactDownloadManager would improve the behaviour for what was tested. That test seems to only use PyPI requirements, not VCS ones.
My understanding is that this error happens eagerly, on construction of this BuildConfiguration object, and so when a VCSArtifactDownloadManager is constructed, it'll eagerly do the checking and throw the error here. And, at least one VCSArtifactDownloadManager is constructed for every resolve-from-lock (one for each subset), thus, failures even when no VCS requirements are involved.
Is that correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #2346, which was released in Pex 2.1.161, using
--only-binary Xwith a
--lockwould fail fast even if the lock itself was created with--only-binary X, which should be compatible.Fixes #2432