Implement support for preserving and injecting Python args. #2427
Conversation
This is the code that ends up in PEX `__main__.py` and it could benefit from formatting, linting and type checking.
This support does not work for `PyPy<3.10` but it does work for all other Pythons Pex supports.
|
This was a good idea from @bkad and it completes the work started by @BrandonTheBuilder in #1746 at PyCon US 2022. I think Pex now supports all Python interpreter args that make sense in all modes of operation. |
|
The tests make sense to me and capture the original request of passing |
| orig_args = orig_argv() | ||
| if orig_args: | ||
| for index, arg in enumerate(orig_args[1:], start=1): | ||
| if os.path.exists(arg) and os.path.samefile(entry_point, arg): | ||
| python_args.extend(orig_args[1:index]) | ||
| break |
There was a problem hiding this comment.
I added some manual timing around this during development - I was a bit worried about the ctypes impl since there is no opt-out even if you don't use Python args and this is in the hot path. The timings were consistently sub-ms for both sys.orig_argv and the ctypes implementation. Almost all the ~O(100us) time for the ctypes version was spent in the imports above where the function is defined. The call here was much faster.
Support preserving and injecting Python args.
Pex now supports
--inject-python-argssimilar to--inject-argsbutfor specifying arguments to pass to the Python interpreter as opposed to
arguments to pass to the application code. This is supported for both
zipapp and venv execution modes as well as standard shebang launching,
launching via a Python explicitly or via the
--sh-bootmechanism.In addition, PEX files now support detecting and passing through Python
args embedded in shebangs or passed explicitly on the command line for
all Pythons Pex supports save for
PyPy<3.10where there appears to beno facility to retrieve the original argv PyPy was executed with.
Closes #2422