Since we no longer use wheel code, remove it. #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of changes over a long time have led to this point. The last small one is in this change, installing wheel in the vendored Pip venv just in time when wheel building is required by using vendored Pip itself and the user configured indexes, etc.
jsirois
commented
Dec 14, 2023
| @@ -641,20 +641,11 @@ def _prepare_bootstrap(self): | |||
| # although we don't use pyparsing directly, packaging.markers, which we | |||
| # do use at runtime, does. | |||
| root_module_names = ["attr", "packaging", "pkg_resources", "pyparsing"] | |||
| include_dist_info = set() | |||
| if self._pex_info.includes_tools: | |||
| # The `repository extract` tool needs setuptools and wheel to build sdists and wheels | |||
There was a problem hiding this comment.
This is covered by pre-existing tests and was made untrue by the commits that made way for Python 3.12 support this summer (See: https://github.com/pantsbuild/pex/pull/2172/files#diff-7f155c6651ad8c550123265bf6297eee5e5074ba2152a8c99c6f6128b7e58103R52-L267). The savings in no longer vendoring these both for the Pex PEX (which --includes-tools) can be seen in this comparison of end products:
$ du -sh released/* dist/*
4.1M released/pex
2.9M released/pex-2.1.154-py2.py3-none-any.whl
3.9M released/pex-2.1.154.tar.gz
3.6M dist/pex
2.8M dist/pex-2.1.154-py2.py3-none-any.whl
3.9M dist/pex-2.1.154.tar.gz
kaos
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes over a long time have led to this point. The last small
one is in this change, installing wheel in the vendored Pip venv just in
time when wheel building is required by using vendored Pip itself and
the user configured indexes, etc.