Unescapes html in PageParser.href_match_to_url

[daveFNbuck]

PageParser breaks if the links contain any escaped html characters. This fixes that bug.

[kwlzn]

would you mind also adding a quick test for this?

one mild concern to call out: this introduces a dependency on the xml.* class of stdlib modules which, depending on the environment python was compiled in (e.g. lacking supporting xml devel packages), may or may not be present in the stdlib on some systems/interpreters. I suppose that's sort of outside of our scope here tho - and I don't see a great portable alternative to xml.sax.saxutils.unescape short of writing our own.

[daveFNbuck]

Sure, I can add a quick test. https://wiki.python.org/moin/EscapingHtml
suggests a short function we can use if the xml lib not existing is a
problem for some people. All I really need is the s.replace('&', '&')
line, as the issue I'm having is with parameters being passed in the url on
my custom pypi server.

On Fri, Jan 1, 2016 at 11:48 AM, Kris Wilson [email protected]
wrote:

would you mind also adding a quick test for this?

one mild concern to call out: this introduces a dependency on the xml.*
class of stdlib modules which, depending on the environment python was
compiled in (e.g. lacking supporting xml devel packages), may or may not be
present in the stdlib on some systems/interpreters. I suppose that's sort
of outside of our scope here tho - and I don't see a great portable
alternative to xml.sax.saxutils.unescape short of writing our own.

—
Reply to this email directly or view it on GitHub
#191 (comment).

[daveFNbuck]

ping

[kwlzn]

lgtm!

[kwlzn]

thanks @daveFNbuck - this should be going out in the 1.1.2 release later today/tomorrow.

[daveFNbuck]

Awesome, thanks!

On Thu, Jan 7, 2016 at 2:12 PM, Kris Wilson [email protected]
wrote:

thanks @daveFNbuck https://github.com/daveFNbuck - this should be going
out in the 1.1.2 release later today/tomorrow.

—
Reply to this email directly or view it on GitHub
#191 (comment).