Requirement parsing handles local non-dist files. #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a file (not directory) in the CWD with the same name as the project name of a requirement being resolved would lead to an error. Modify the requirement parsing stress test to cause this error and fix parsing so the test passes. Fixes pex-tool#1188
Eric-Arellano
approved these changes
Jan 22, 2021
Comment on lines
+313
to
+315
| # Ensure local non-distribution files matching distribution names are not erroneously probed | ||
| # as distributions to find name and version metadata. | ||
| touch("nose") |
There was a problem hiding this comment.
One thing I appreciate about your PEX tests is explicitly mentioning the motivating issue in things like test names. Consider adding a link to the issue in this comment.
(Not a huge deal - Git history will trace it back.)
There was a problem hiding this comment.
Yeah - its a cheap / sneaky / convenient / lazy test. Agreed about git history though. Now that the black reformat is past, git blame is pretty useful for exactly this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a file (not directory) in the CWD with the same name as the
project name of a requirement being resolved would lead to an error.
Modify the requirement parsing stress test to cause this error and fix
parsing so the test passes.
Fixes #1188