Tighten requirements parsing. #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to fix pex-tool#899, we need to map local project requirements to built wheels after the fact in order to learn the project name and version and thus the full requirement needed for PexInfo metadata. In order to do this with confidence, break up the ReqInfo type into three seperate types to cover the three main parse cases.
Eric-Arellano
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix #899, we need to map local project requirements to built
wheels after the fact in order to learn the project name and version and
thus the full requirement needed for PexInfo metadata. In order to do
this with confidence, break up the ReqInfo type into three seperate
types to cover the three main parse cases.