Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose network configuration in pex options. #803

Closed
jsirois opened this issue Nov 22, 2019 · 2 comments · Fixed by #974
Closed

Expose network configuration in pex options. #803

jsirois opened this issue Nov 22, 2019 · 2 comments · Fixed by #974

Comments

@jsirois
Copy link
Member

jsirois commented Nov 22, 2019

In particular, these pip options should be plumbed through from the pex CLI & the resolver API:

  -H, --header <key:val>      HTTP header to include in all requests. This option can be used multiple times. Conflicts with --extra-index-url.
  --proxy <proxy>             Specify a proxy in the form [user:passwd@]proxy.server:port.
  --retries <retries>         Maximum number of retries each connection should attempt (default 5 times).
  --timeout <sec>             Set the socket timeout (default 15 seconds).
  --trusted-host <hostname>   Mark this host as trusted, even though it does not have valid or any HTTPS.
  --cert <path>               Path to alternate CA bundle.
  --client-cert <path>        Path to SSL client certificate, a single file containing the private key and the certificate in PEM format.
@jsirois
Copy link
Member Author

jsirois commented Nov 22, 2019

See #26

@jsirois
Copy link
Member Author

jsirois commented May 11, 2020

Noting we already handle --trusted-host by implicitly trusting any custom indexes or find links repos specified by the user. This may still leave some corner cases unhandled that use re-directed storage (I think antlr3 did this), but probably fine until a need is demonstrated.

@benjyw benjyw mentioned this issue May 11, 2020
10 tasks
jsirois added a commit to jsirois/pex that referenced this issue May 11, 2020
Also add back the `--cache-ttl` option from Pex 1.x and plumb the header
needed to make it so.

Also remove long-ignored `PEX_HTTP_RETRIES` and `PEX_HTTP_TIMEOUT` env
var support.

Fixes pex-tool#94
Fixes pex-tool#803
jsirois added a commit that referenced this issue May 12, 2020
Also add back the `--cache-ttl` option from Pex 1.x and plumb the header
needed to make it so.

Also remove long-ignored `PEX_HTTP_RETRIES` and `PEX_HTTP_TIMEOUT` env
var support.

Fixes #94
Fixes #803

Co-authored-by: Eric Arellano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant