Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypy shards in travisCI can fail with 'too many open files' errors #497

Closed
kwlzn opened this issue May 24, 2018 · 4 comments
Closed

pypy shards in travisCI can fail with 'too many open files' errors #497

kwlzn opened this issue May 24, 2018 · 4 comments
Assignees

Comments

@kwlzn
Copy link
Contributor

kwlzn commented May 24, 2018

this needs more investigation, but intermittently only the "pypy" shards in travis will fail arbitrarily with "too many open files" errors.

we had previously pinned to the travis precise image because of this, but because of deprecation prompting for that image we'd jumped forward here: #476

an initial pass may want to try some simple ulimit tuning.

This was referenced May 26, 2018
@kwlzn
Copy link
Contributor Author

kwlzn commented Jun 5, 2018

filed travis-ci/travis-ci#9706 for some upstream help.

@kwlzn
Copy link
Contributor Author

kwlzn commented Jun 9, 2018

topical relief achieved in #513 here: https://travis-ci.org/pantsbuild/pex/builds/390035309

at a cost of ~4x test execution time (~2m -> ~8m) - good enough to tide us over for now.

@jsirois
Copy link
Member

jsirois commented Nov 21, 2018

I found the bug and it is in pypy. I need to work around it for other reasons, and it turns out this fixes our pypy shard which can now run normally. Re-opening to linkup the fix PR and add bug links.

@jsirois jsirois reopened this Nov 21, 2018
@jsirois jsirois self-assigned this Nov 21, 2018
@jsirois
Copy link
Member

jsirois commented Nov 21, 2018

jsirois added a commit to jsirois/pex that referenced this issue Nov 26, 2018
Previously, pex would blow up trying to adjust import paths if a PEP-420
implicit namespace package was encountered. Add a test of the path
adjustment functionality both to confirm it was needed (it was) and that
the fix technique works with all forms of namespace packages by only
assuming they support `append`.

To support all this, work around a pypy zipimporter bug:
https://bitbucket.org/pypy/pypy/issues/1686 and, as a side-effect,
eliminate our CI workaround for the pypy unit test shard.

Fixes pex-tool#598
Fixes pex-tool#497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants