Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special case lock updates that are pure delete. #2566

Closed
jsirois opened this issue Oct 23, 2024 · 1 comment · Fixed by #2569
Closed

Special case lock updates that are pure delete. #2566

jsirois opened this issue Oct 23, 2024 · 1 comment · Fixed by #2569
Assignees
@jsirois
Labels
enhancement performance resolver

Comments

@jsirois
Copy link
Member

jsirois commented Oct 23, 2024

If a lock is being updated - via pex3 lock {sync,update} - and all updates are deletes, Pip need not be consulted at all. Pex can simply walk the graph from the delete roots and remove all locked requirements no longer referenced.
@jsirois jsirois self-assigned this Oct 23, 2024
@jsirois
Copy link
Member Author

jsirois commented Oct 23, 2024

The original impetus was an observation by @benjyw in #2565.

jsirois added a commit to jsirois/pex that referenced this issue Oct 23, 2024
@jsirois
Optimize pure delete lock updates.
eece161 
When a lock update only asks for deletes, we now process the "resolve"
offline without consulting Pip.

Fixes pex-tool#2566
@jsirois jsirois mentioned this issue Oct 23, 2024
Merged
@github-project-automation github-project-automation bot moved this from To do to Done in Lock File Support Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
enhancement performance resolver
Projects
Lock File Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize pure delete lock updates. jsirois/pex
1 participant
@jsirois