Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Pip's --only-binary / --no-binary. #2343

Closed
jsirois opened this issue Jan 23, 2024 · 1 comment · Fixed by #2346
Closed

Support Pip's --only-binary / --no-binary. #2343

jsirois opened this issue Jan 23, 2024 · 1 comment · Fixed by #2346
Assignees
@jsirois
Labels
feature request resolver

Comments

@jsirois
Copy link
Member

jsirois commented Jan 23, 2024

This would require being able to parse the flag in requirements files as well as providing Pex top-level flags for the option as well.
@jsirois jsirois mentioned this issue Jan 23, 2024
Closed
@jsirois jsirois self-assigned this Jan 25, 2024
@jsirois
Copy link
Member Author

jsirois commented Jan 25, 2024

The status-quo with --prefer-binary is just to plumb the option and not attempt to read it from requirements files. I'll stick with that status quo here and I've filed #2345 to track being able to augment CLI options via requirement file parsing.

jsirois added a commit to jsirois/pex that referenced this issue Jan 26, 2024
@jsirois
Plumb Pip's --{no,only}-binary.
111cfae 
Previously, Pex just allowed specifying `--no-wheel` or `--no-build`
globally. Now, individual projects can be slated for `--only-wheel` or
`--only-build` just as they can with Pip. In the lock case, this
information is saved so that lock updates carry the configuration
forward.

Fixes pex-tool#2343
@jsirois jsirois mentioned this issue Jan 26, 2024
Merged
jsirois added a commit that referenced this issue Jan 26, 2024
@jsirois @kaos
Plumb Pip's --{no,only}-binary. (#2346)
23c3c06 
Previously, Pex just allowed specifying `--no-wheel` or `--no-build`
globally. Now, individual projects can be slated for `--only-wheel` or
`--only-build` just as they can with Pip. In the lock case, this
information is saved so that lock updates carry the configuration
forward.

Fixes #2343

---------

Co-authored-by: Andreas Stenius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
feature request resolver
Projects
Lock File Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plumb Pip's --{no,only}-binary. jsirois/pex
1 participant
@jsirois