-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update on lock with acryl-datahub fails with cryptic error message #2324
Comments
@cburroughs I won't have time to work on this until tomorrow afternoon. The verified flag indicates whether the artifact hash has been calculated by Pex itself ( |
Noting this fixes: $ git diff
diff --git a/pex/resolve/locked_resolve.py b/pex/resolve/locked_resolve.py
index 241cb837..c4421063 100644
--- a/pex/resolve/locked_resolve.py
+++ b/pex/resolve/locked_resolve.py
@@ -148,7 +148,7 @@ class Artifact(object):
url = attr.ib() # type: str
fingerprint = attr.ib() # type: Fingerprint
- verified = attr.ib() # type: bool
+ verified = attr.ib(eq=False) # type: bool
def __lt__(self, other):
# type: (Any) -> bool An integration test is needed to prevent backslide though as well as a note explaining why this is right to ignore in |
Previously, a `pex3 lock update` would fail whenever bystander projects (those projects in the lock but not targeted for update via `-p`) had an sdist primary artifact. Fixes pex-tool#2324
Previously, a `pex3 lock update` would fail whenever bystander projects (those projects in the lock but not targeted for update via `-p`) had an sdist primary artifact. Fixes #2324
@cburroughs thanks for using the lock update feature and the bug report. the fix for this is now released in Pex 2.1.157: https://github.com/pantsbuild/pex/releases/tag/v2.1.157 |
Thanks for the quick fix! |
To get some more details with
PEX_VERBOSE=10
:With some dinosaur
print
debugging:Which I believe simplifies to:
Which I think shows why the assertion was triggered, but I still don't see what about this package is tickling the
verified
main
avro==1.11.3
instead ofacryl-datahub==0.12.0.5
in the originalcreate
also fails in the same way.The text was updated successfully, but these errors were encountered: