Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PexInfo.copy does not copy its collection attributes. #1147

Closed
jsirois opened this issue Dec 16, 2020 · 0 comments · Fixed by #1148
Closed

PexInfo.copy does not copy its collection attributes. #1147

jsirois opened this issue Dec 16, 2020 · 0 comments · Fixed by #1148
Assignees
@jsirois
Labels
bug

Comments

@jsirois
Copy link
Member

jsirois commented Dec 16, 2020

The copy method was oversimplified in #1127 and now only copies the dict backing the non-collection attributes of PexInfo.
@jsirois jsirois added the bug label Dec 16, 2020
@jsirois jsirois self-assigned this Dec 16, 2020
@jsirois jsirois mentioned this issue Dec 16, 2020
Closed
11 tasks
jsirois added a commit to jsirois/pex that referenced this issue Dec 16, 2020
@jsirois
Fix PexInfo.copy.
ce9ba82 
Fixes pex-tool#1147
@jsirois jsirois mentioned this issue Dec 16, 2020
Merged
jsirois added a commit that referenced this issue Dec 16, 2020
@jsirois
Fix PexInfo.copy. (#1148)
e3a85f0 
Fixes #1147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PexInfo.copy. jsirois/pex
1 participant
@jsirois