Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --sources-directory / --resources-directory distinction. #1100

Closed
jsirois opened this issue Nov 6, 2020 · 1 comment · Fixed by #1103
Closed

Remove --sources-directory / --resources-directory distinction. #1100

jsirois opened this issue Nov 6, 2020 · 1 comment · Fixed by #1103
Assignees
@jsirois
Labels
tech-debt Issue that addresses technical debt.

Comments

@jsirois
Copy link
Member

jsirois commented Nov 6, 2020

We do nothing different when gathering these for inclusion in a PEX file. They all just get copied into the PEX file chroot.
@jsirois jsirois added the tech-debt Issue that addresses technical debt. label Nov 6, 2020
@jsirois
Copy link
Member Author

jsirois commented Nov 6, 2020

Noticed investigating os.walks in #1099.

jsirois added a commit to jsirois/pex that referenced this issue Nov 7, 2020
@jsirois
Deprecate -R/--resources-directory.
921da8d 
Fixes pex-tool#1100
@jsirois jsirois self-assigned this Nov 7, 2020
This was referenced Nov 7, 2020
Closed
Merged
jsirois added a commit that referenced this issue Nov 7, 2020
@jsirois
Deprecate -R/--resources-directory. (#1103)
4524bd0 
Fixes #1100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
tech-debt Issue that addresses technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate -R/--resources-directory. jsirois/pex
1 participant
@jsirois