Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing vendored versions does not fully clean up previous version #1096

Closed
stuhood opened this issue Nov 3, 2020 · 0 comments · Fixed by #1106
Closed

Changing vendored versions does not fully clean up previous version #1096

stuhood opened this issue Nov 3, 2020 · 0 comments · Fixed by #1106
Assignees
@jsirois
Labels
bug

Comments

@stuhood
Copy link

stuhood commented Nov 3, 2020 •
edited
Loading

After changing from pip 20.0.dev0 to 20.2.4 in pex/vendor/__init__.py, some orphaned files were left behind in the _vendored directory which interfered with the ability to load the module later:

D  pex/vendor/_vendored/pip/pip-20.0.dev0.dist-info/INSTALLER
D  pex/vendor/_vendored/pip/pip-20.0.dev0.dist-info/LICENSE.txt
D  pex/vendor/_vendored/pip/pip-20.0.dev0.dist-info/METADATA
D  pex/vendor/_vendored/pip/pip-20.0.dev0.dist-info/WHEEL
D  pex/vendor/_vendored/pip/pip-20.0.dev0.dist-info/entry_points.txt
D  pex/vendor/_vendored/pip/pip-20.0.dev0.dist-info/top_level.txt

Running

git rm -r pex/vendor/_vendored/pip
tox -e vendor
git add pex/vendor/_vendored/pip

...resolved the issue.

I was already yak shaving, so didn't dive in to investigate. But I expect that fully removing the vendor directory before re-vendoring would resolve this.
@stuhood stuhood added the bug label Nov 3, 2020
@stuhood stuhood mentioned this issue Nov 3, 2020
Open
jsirois added a commit to jsirois/pex that referenced this issue Nov 7, 2020
@jsirois
Clear any prior vendorings when (re)vendoring.
e307a79 
This allows for re-vendored distributions losing files as well as changing
the set of vendored distributions altogether.

Fixes pex-tool#1096
@jsirois jsirois self-assigned this Nov 7, 2020
This was referenced Nov 7, 2020
Merged
Closed
jsirois added a commit that referenced this issue Nov 9, 2020
@jsirois
Clear any prior vendorings when (re)vendoring. (#1106)
668d5f1 
This allows for re-vendored distributions losing files as well as changing
the set of vendored distributions altogether.

Fixes #1096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clear any prior vendorings when (re)vendoring. jsirois/pex
2 participants
@stuhood @jsirois