Skip to content

Commit

Permalink
Add a "so what?" to removing --use-first-matching-interpreter
Browse files Browse the repository at this point in the history
  • Loading branch information
@Eric-Arellano
Eric-Arellano committed Oct 15, 2020
1 parent dfb43e0 commit dc05833
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion CHANGES.rst
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ Release Notes
This release adds the ``--python-path`` option, which allows controlling the
interpreter search paths when building a PEX.

It also removes ``--use-first-matching-interpreter``, which was a misfeature.
It also removes ``--use-first-matching-interpreter``, which was a misfeature. If you want to use
fewer interpreters when building a PEX, use tighter values for ``--interpreter-constraint``,

This comment has been minimized.

Sign in to view

Copy link
@tdyas

tdyas Oct 15, 2020 •
edited
Loading

Contributor

Maybe "narrower" instead of "tighter" since "narrower"/"broader" are more often used with respect to scope?

This comment has been minimized.

Sign in to view

Copy link
@Eric-Arellano

Eric-Arellano Oct 15, 2020

Author Contributor

I've usually heard "loose" vs. "tight" constraints. Perhaps "more precise"?

This comment has been minimized.

Sign in to view

Copy link
@jsirois

jsirois Oct 15, 2020

Member

Maybe just kill the modifiers. A platform is perfectly precise. A --python (which you leave out) is pretty precise.

This comment has been minimized.

Sign in to view

Copy link
@tdyas

tdyas Oct 15, 2020

Contributor

Perhaps "more precise"?

That is fine by me.
``--python-path``, and/or ``--platform``.

* Add ``--python-path`` to change interpreter search paths when building a PEX. (#1077)
`PR #1077 <https://github.com/pantsbuild/pex/pull/1077>`_
Expand Down

0 comments on commit dc05833

Please sign in to comment.