Merge pull request openhab#157 from maggu2810/fix-resource-leak

Resource leak: 'socket' never closed
peuter · Mar 10, 2015 · cc7fa1d · cc7fa1d
2 parents 743bc6c + fcfdefe
commit cc7fa1d
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/bundles/core/org.openhab.core.compat1x/src/main/java/org/openhab/io/net/actions/Ping.java b/bundles/core/org.openhab.core.compat1x/src/main/java/org/openhab/io/net/actions/Ping.java
@@ -50,9 +50,11 @@ public static boolean checkVitality(String host, int port, int timeout) throws I
 			}
 			else {
 				SocketAddress socketAddress = new InetSocketAddress(host, port);
-
-				Socket socket = new Socket();
-				socket.connect(socketAddress, timeout);
+
+                try (Socket socket = new Socket()) {
+                    socket.connect(socketAddress, timeout);
+                }
+
 				success = true;
 			}
 		}