-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal Integration #976
Modal Integration #976
Conversation
I've just implementend the integration method. It's lacking the tests, which I'll be implementing tomorrow. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #976 +/- ##
==========================================
- Coverage 85.56% 85.11% -0.46%
==========================================
Files 34 34
Lines 7530 7650 +120
==========================================
+ Hits 6443 6511 +68
- Misses 1087 1139 +52
Continue to review full report in Codecov by Sentry.
|
@raphaeltimbo I think I've finished the first step which was:
I think it would be better to go slowly, so I will keep this branch without changes until your review. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some small comments for now.
I think we should, in parallel, solve the issue #978, so that we can benchmark this new integrator.
Hi there!
|
We have implemented the newmark integration. |
This PR is devoted to implementing a new integration inside ROSS, using the modal reduction. The main goal is to enable the solution of #429, #530 and #884.
This PR itself, does not solve any of the cited issues yet, i.e., it is a pre solution.