Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregate with key is none #541

Merged
merged 5 commits into from
Feb 3, 2021
Merged

Aggregate with key is none #541

merged 5 commits into from
Feb 3, 2021

Conversation

bmaggard
Copy link
Contributor

@bmaggard bmaggard commented Feb 1, 2021 •
edited by juarezr
Loading

Changes

Allow aggregation over the entire table (without a key)

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • (Optional) Just a proof of concept
    • (Optional) Work in progress
    • Ready to review
    • Ready to merge

@coveralls
Copy link

coveralls commented Feb 1, 2021 •
edited
Loading

Coverage Status

Coverage increased (+1.0%) to 91.903% when pulling ff66047 on bmaggard:aggregate_with_key_is_None into 0a40801 on petl-developers:master.

juarezr
juarezr approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@juarezr juarezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Maybe @alimanfoo can further review it.

@juarezr juarezr added Feature A nice to have thing that we don't have yet Usability Improvement that benefit petl usage for end users labels Feb 1, 2021
@juarezr juarezr merged commit b1eafde into petl-developers:master Feb 3, 2021
@bmaggard bmaggard deleted the aggregate_with_key_is_None branch February 3, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juarezr juarezr juarezr approved these changes

@alimanfoo alimanfoo Awaiting requested review from alimanfoo

Assignees
No one assigned
Labels
Feature A nice to have thing that we don't have yet Usability Improvement that benefit petl usage for end users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmaggard @coveralls @juarezr