Buttons Block: Show inserter if button have variations (WordPress#53498)

petitphp · Sep 11, 2023 · 4e7c858 · 4e7c858
1 parent c10b0f6
commit 4e7c858
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/packages/block-library/src/buttons/edit.js b/packages/block-library/src/buttons/edit.js
@@ -12,6 +12,7 @@ import {
 	store as blockEditorStore,
 } from '@wordpress/block-editor';
 import { useSelect } from '@wordpress/data';
+import { store as blocksStore } from '@wordpress/blocks';
 
 /**
  * Internal dependencies
@@ -49,10 +50,18 @@ function ButtonsEdit( { attributes, className } ) {
 		return preferredStyleVariations?.value?.[ buttonBlockName ];
 	}, [] );
 
+	const hasButtonVariations = useSelect( ( select ) => {
+		const buttonVariations = select( blocksStore ).getBlockVariations(
+			buttonBlockName,
+			'inserter'
+		);
+		return buttonVariations.length > 0;
+	}, [] );
+
 	const innerBlocksProps = useInnerBlocksProps( blockProps, {
 		allowedBlocks: ALLOWED_BLOCKS,
 		defaultBlock: DEFAULT_BLOCK,
-		directInsert: true,
+		directInsert: ! hasButtonVariations,
 		template: [
 			[
 				buttonBlockName,