fix matching boolean attribute

peternewnham · May 7, 2016 · 1edc2d0 · 1edc2d0
1 parent 86d876c
commit 1edc2d0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/utils/HtmlAttributesToReact.js b/src/utils/HtmlAttributesToReact.js
@@ -12,7 +12,8 @@ const getParsedAttributeValue = function(attribute, value) {
 
   // if the attribute if a boolean then it's value should be the same as it's name
   // e.g. disabled="disabled"
-  if (BooleanAttributes.indexOf(attribute) >= 0) {
+  let lowerBooleanAttributes = BooleanAttributes.map(attr => attr.toLowerCase());
+  if (lowerBooleanAttributes.indexOf(attribute.toLowerCase()) >= 0) {
     value = attribute;
   }
 

diff --git a/test/unit/utils/HtmlAttributesToReact.spec.js b/test/unit/utils/HtmlAttributesToReact.spec.js
@@ -22,22 +22,24 @@ describe('Testing `utils/HtmlAttributesToReact`', () => {
       'UPPER-CASE-TEST-ATTRIBUTE': 'upperTestAttribute',
       // boolean attributes
       disabled: '',
-      checked: ''
+      checked: '',
+      autoplay: ''
     };
 
     const expectedReactAttributes = {
       className: 'testClass',
       htmlFor: 'testFor',
       minLength: 1,
       acceptCharset: 'testAcceptCharset',
-      formNoValidate: 'testFormNoValidate',
+      formNoValidate: 'formNoValidate',
       label: 'testLabel',
       'data-test': 'test',
       'aria-role': 'role',
       testattribute: 'testAttribute',
       'upper-case-test-attribute': 'upperTestAttribute',
       disabled: 'disabled',
-      checked: 'checked'
+      checked: 'checked',
+      autoPlay: 'autoPlay'
     };
 
     expect(HtmlAttributesToReact(htmlAttributes)).toEqual(expectedReactAttributes);