Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ami-dictionaries directory option not working as expected #12

Open
ay-amityadav opened this issue Feb 8, 2019 · 6 comments
Open

ami-dictionaries directory option not working as expected #12

ay-amityadav opened this issue Feb 8, 2019 · 6 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@ay-amityadav
Copy link
Collaborator

Operating system: Ubuntu 16.04

To create dictionary from wikipedia page of millet, as described at https://github.com/ContentMine/dictionaries/blob/master/MAKING.md, the following command is issued.

ami-dictionaries create\
 --hreftext \
 --input https://en.wikipedia.org/wiki/Millet\
 --informat wikipage\
 --dictionary millets_wikipage \
 --outformats xml,json,html
 --directory /home/amit/Desktop/Workshop/Github/tigr2ess/millets/dictionary

I was hoping to get the dictionary files at the path specified by --directory option above. Instead, the concerned dictionary files were created as per the below directory structure under /home/amit/ .

~
├── ContentMine
│   ├── dictionary
│       └── dictionaries
|            └── millets_wikipage.html
|            └── millets_wikipage.json
|            └── millets_wikipage.xml

And the following (apparently not required for the concerned purpose) directory structure was created in the current working directory.

.
├── target
│   ├── dictionary
│       └── htmlElement.html

The above behaviour was also observed for all the four different dictionary creation examples present in https://github.com/ContentMine/dictionaries/blob/master/MAKING.md.

@ay-amityadav ay-amityadav added the bug Something isn't working label Feb 8, 2019
@petermr
Copy link
Owner

petermr commented Feb 9, 2019 via email

@petermr
Copy link
Owner

petermr commented Feb 16, 2019

Please retest and verify correction.

@petermr petermr closed this as completed Feb 16, 2019
@ay-amityadav
Copy link
Collaborator Author

This is tested on the latest release i.e ami20190216b
The above issue is partially resolved.
The dictionary files are correctly created in the specified directory option, but the two not so required directories are still created:

  • Contentmine under the home directory
  • target in the current working directory (this is not created for dictionary creation from terms)

I am attaching a test script for the same. I hope it helps. Please change the file extension to .sh, Github didn't allow me to upload file with that extension.
test_issue_12.txt

@ay-amityadav ay-amityadav reopened this Feb 17, 2019
@petermr
Copy link
Owner

petermr commented Feb 17, 2019 via email

@petermr
Copy link
Owner

petermr commented Feb 17, 2019 via email

@ay-amityadav
Copy link
Collaborator Author

I tested the script amit_test.sh on the latest release i.e ami20190217. I have made minor changes to it, and now it's working properly.

@petermr petermr added the wontfix This will not be worked on label Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants