roachtest: add acceptance/version-upgrade

Move the version-upgrade acceptance test to a new acceptance/version-upgrade roachtest. See cockroachdb#29151 Release note: None
petermattis · Sep 4, 2018 · c5bed83 · c5bed83
1 parent 14b53bc
commit c5bed83
Show file tree

Hide file tree

Showing 4 changed files with 302 additions and 345 deletions.
diff --git a/pkg/acceptance/localcluster/cluster.go b/pkg/acceptance/localcluster/cluster.go
@@ -319,18 +319,6 @@ func (c *Cluster) makeNode(ctx context.Context, nodeIdx int, cfg NodeConfig) (*N
 	return n, ch
 }
 
-// RemoveNodeData removes the given node's data directory.
-func (c *Cluster) RemoveNodeData(nodeIdx int) error {
-	dir := c.Cfg.PerNodeCfg[nodeIdx].DataDir
-	return os.RemoveAll(dir)
-}
-
-// ReplaceBinary replaces the binary that will be used for the specified node
-// after its next restart.
-func (c *Cluster) ReplaceBinary(nodeIdx int, bin string) {
-	c.Nodes[nodeIdx].Cfg.ExtraArgs[0] = bin
-}
-
 // waitForFullReplication waits for the cluster to be fully replicated.
 func (c *Cluster) waitForFullReplication() {
 	for i := 1; true; i++ {

diff --git a/pkg/acceptance/version_upgrade_test.go b/pkg/acceptance/version_upgrade_test.go
diff --git a/pkg/cmd/roachtest/acceptance.go b/pkg/cmd/roachtest/acceptance.go
@@ -44,6 +44,7 @@ func registerAcceptance(r *registry) {
 		{"gossip/restart-node-one", runGossipRestartNodeOne},
 		{"rapid-restart", runRapidRestart},
 		{"status-server", runStatusServer},
+		{"version-upgrade", runVersionUpgrade},
 	}
 	for _, tc := range testCases {
 		tc := tc