--name should work both as a positional arg and as an option arg
#403
Conversation
|
@peterhuene thoughts? |
| name: args.value_of("name").unwrap(), | ||
| name: args.value_of("positional-name").unwrap_or_else(|| { | ||
| args.value_of("name") | ||
| .unwrap_or("Default fallback - never reached") |
There was a problem hiding this comment.
Can this be an expect instead?
There was a problem hiding this comment.
If so, this comment applies to each command.
There was a problem hiding this comment.
Hi @ajnirp. Sorry for the delay in following up with you. I'd like to get this merged soon. Did you see this review question, namely changing unwrap_or to expect? Thanks!
There was a problem hiding this comment.
The CI checks for cargo fmt -- --check and cargo clippy --release -- --Dwarnings are failing, but those same commands are working (i.e. $? is 0) for me locally. Any idea what I might be missing?
There was a problem hiding this comment.
The clippy error is from generated code that we can ignore for now.
The rustfmt one is odd. The CI uses the latest stable, so if you're also using the latest stable I can't explain the difference.
Let me look into this tonight if I can; I won't block merging your PR for a format / linter error, though.
|
Hi @ajnirp. Sorry I was on vacation last week. The changes look great! I just have the one question. Thanks again for fixing this issue! |
|
Apologies for the late reply - I'll get around to it this weekend! I have no access to a personal machine for coding until then. Thank you for the review! |
This is enabled by creating a separate, `required`, positional arg and making it conflict with the original optional arg. I applied this change to each subcommand of `cargo func new`.
This commit fixes the formatting of `binding.rs` with the latest stable toolset.
This commit ignores the lint warning for type repetition in bounds for the gRPC generated code.
|
It looks like the only failure is the nightly As such, I'm going to ignore that failure. @ajnirp thanks very much for the contribution! |
This is enabled by creating a separate,
required, positional arg and making it conflict with the original optional arg. I applied this change to each subcommand ofcargo func new.What is the goal of this pull request?
It addresses #374
What does this pull request change?
A user creating a new Azure Function can leave out the
--nameoption while doing so. They must still provide a name, as before.What work remains to be done?
None.
Do you consider it adequately tested?
Yes - I reinstalled the SDK with
cargo install, then tested new behaviour with these commands:cargo func new help httpcargo func new http abc --auth-level anonymouscargo func new http --auth-level anonymous abccargo func new http --auth-level anonymous --name abcRelated Issues
None
Notes
N.A.