This repository has been archived by the owner on Jun 2, 2020. It is now read-only.
Remove export! macro. #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `export!` macro from `azure-functions`. The macro was previously used to declare the given modules as well as generate a `FUNCTIONS` constant passed to the main function. Unfortunately because the modules were being defined dynamically, syntax errors in the function source files would mean a completely undiagnosable error message would be emitted by the compiler pointing at the `export!` macro. The fix is to remove the `export!` macro entirely and implement a more sophisticated `cargo func new` that relies on no macro implementations. Fixes #335.
peterhuene
added
the
breaking change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
export!macro fromazure-functions.The macro was previously used to declare the given modules as well as generate
a
FUNCTIONSconstant passed to the main function.Unfortunately because the modules were being defined dynamically, syntax errors
in the function source files would mean a completely undiagnosable error
message would be emitted by the compiler pointing at the
export!macro.The fix is to remove the
export!macro entirely and implement a moresophisticated
cargo func newthat relies on no macro implementations.Fixes #335.