Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed discriminator display bug #22

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

farkon00
Copy link
Contributor

Fixed bug with discriminator displaying without zeros. Eg my discriminator is #0500, but discord-package was displaying it as #500.

@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for discordpackage ready!

Name Link
🔨 Latest commit 751cb0a
🔍 Latest deploy log https://app.netlify.com/sites/discordpackage/deploys/6356b330b242600009bb55f7
😎 Deploy Preview https://deploy-preview-22--discordpackage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@farkon00
Copy link
Contributor Author

farkon00 commented Oct 24, 2022

Difference
image

Copy link
Contributor

@3kh0 3kh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the preview it works!

@peterhanania peterhanania requested review from 3kh0 and peterhanania and removed request for 3kh0 October 24, 2022 22:00
Copy link
Owner

@peterhanania peterhanania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.

before updating can you make sure all discriminators work? If you could try editing your disc several times and make sure it works and let me know if you find another bug, if not reply to this and I will approve.

@farkon00
Copy link
Contributor Author

@peterhanania Yes i checked, but without the app. Just pasted discriminator code into regular ts script and replaced getting discriminator from data object with a varaible. It worked.

@peterhanania
Copy link
Owner

DM me for your role :)

@peterhanania peterhanania merged commit 6c0197d into peterhanania:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants