-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mention the tools.go approach to pin tool version #92
Comments
Hey @marco-m,
Absolutely.
That would be awesome. I'd be happy to merge it, thank you!
Sounds good to me. Appreciate your help! |
FYI, there is a (somewhat) associated bug to doing the tools package in |
@jpopadak Apparently it's by design, not a bug. See #91 (comment) where I list a couple of related issues, in which some people argue that it works as designed. I think I disagree. Anyway, for pegomock the problem is now solved in |
@jpopadak thanks for the heads up. I will validate the instructions in the PR after the merge of |
* Explain how to track tool dependencies Closes #92 * Change wording according to review comments * Move new section according to review comments
@marco-m Thank you very much for your contribution! Just merged it. |
Thank you for pegomock and your kind professionalism in handling contributions! |
Hello, thanks for pegomock! :-)
would it make sense to mention the tools.go approach to ensure that the pegomock executable is the same version for everybody using it an given project? I learned this from counterfeiter documentation and is explained in the Go module docs.
If you agree, I would be happy to provide a PR. Where in the README would you like it? I was thinking just after section "Generating Your First Mock and Using It".
The text was updated successfully, but these errors were encountered: