Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention the tools.go approach to pin tool version #92

Closed
marco-m opened this issue Sep 23, 2019 · 6 comments · Fixed by #93
Closed

docs: mention the tools.go approach to pin tool version #92

marco-m opened this issue Sep 23, 2019 · 6 comments · Fixed by #93

Comments

@marco-m
Copy link
Contributor

marco-m commented Sep 23, 2019

Hello, thanks for pegomock! :-)

would it make sense to mention the tools.go approach to ensure that the pegomock executable is the same version for everybody using it an given project? I learned this from counterfeiter documentation and is explained in the Go module docs.

If you agree, I would be happy to provide a PR. Where in the README would you like it? I was thinking just after section "Generating Your First Mock and Using It".

@petergtz
Copy link
Owner

Hey @marco-m,

would it make sense to mention the tools.go approach to ensure that the pegomock executable is the same version for everybody using it an given project?

Absolutely.

If you agree, I would be happy to provide a PR.

That would be awesome. I'd be happy to merge it, thank you!

I was thinking just after section "Generating Your First Mock and Using It".

Sounds good to me.

Appreciate your help!
Peter

marco-m added a commit to marco-m/pegomock that referenced this issue Sep 23, 2019
@jpopadak
Copy link
Contributor

jpopadak commented Sep 25, 2019

FYI, there is a (somewhat) associated bug to doing the tools package in go mod tidy for Go 1.13.
golang/go#34514

@petergtz
Copy link
Owner

@jpopadak Apparently it's by design, not a bug. See #91 (comment) where I list a couple of related issues, in which some people argue that it works as designed.

I think I disagree. Anyway, for pegomock the problem is now solved in develop and I will merge it to master this week.

@marco-m
Copy link
Contributor Author

marco-m commented Sep 25, 2019

@jpopadak thanks for the heads up. I will validate the instructions in the PR after the merge of develop.

petergtz pushed a commit that referenced this issue Sep 30, 2019
* Explain how to track tool dependencies

Closes #92

* Change wording according to review comments

* Move new section according to review comments
@petergtz
Copy link
Owner

@marco-m Thank you very much for your contribution! Just merged it.

@marco-m
Copy link
Contributor Author

marco-m commented Sep 30, 2019

Thank you for pegomock and your kind professionalism in handling contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants