Added timecode generation to video-only remuxing #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might as well add this to |
|
Hmm. The timecode would only be accurate to the second, not nanosecond (since there are no video frames so we can't get an FPS). So it's not very useful - that amount of information is already in the filename? |
|
Ok, sounds a reasonable argument to me. |
|
unrelated - I have a problem with a 4K .ubv file, is there a channel I could contact you on? (happy to pay for your time) |
|
Sure! [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #30 added timecode support but forgot to add it to video-only remuxing, so cameras without audio didn't end up with the timecode. This PR fixes the bug.