Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add permissionless #5

Merged
merged 5 commits into from
Mar 16, 2024
Merged

Feat/add permissionless #5

merged 5 commits into from
Mar 16, 2024

Conversation

jamesmccomish
Copy link
Collaborator

  • add permissionless setup file
  • private key style call to Onit factory to create safe 4337 account

Copy link

vercel bot commented Mar 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spc-wallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 16, 2024 9:52pm

* main:
  fix: store connected dapp
  hotfix: add remove flag to wallet build
  chore update gitignore
  write the key to the database
  update wallet origin
  fix tsconfig
  move wallet to vercel
  add ssr to wallet
  [studio] Add GitHub Action
  hidden frame on away
  remove dead code
  send the credential from the wallet to dapp
  wip create a fallback if no credential exists
  attempt to add display items
Copy link

gitguardian bot commented Mar 16, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10014341 Triggered Generic High Entropy Secret 4f1e5a9 apps/dapp/src/components/create-payment-button.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@jamesmccomish jamesmccomish merged commit efa4142 into main Mar 16, 2024
2 of 4 checks passed
@jamesmccomish jamesmccomish deleted the feat/add-permissionless branch March 16, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant