Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]:fix install repo is id bug #460

Merged
merged 2 commits into from
Nov 12, 2024
Merged

[fix]:fix install repo is id bug #460

merged 2 commits into from
Nov 12, 2024

Conversation

ch-liuzhide
Copy link
Contributor

@ch-liuzhide ch-liuzhide commented Nov 12, 2024 •
edited by xingwanying
Loading

close #458

@vercel Vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
petercat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:38am

@petercat-assistant PeterCat Assistant
Copy link

Walkthrough

This pull request addresses a bug related to the installation repository ID by converting the owner_id and repo_id to strings in the server/github_app/router.py file. Additionally, it updates the server/README.zh-CN.md with development preparation instructions, including installing necessary tools like Python, Supabase CLI, and AWS CLI.

Changes

File Summary
server/README.zh-CN.md Added development preparation instructions, including installation of Python, Supabase CLI, and AWS CLI.
server/github_app/router.py Fixed bug by converting owner_id and repo_id to strings to prevent potential ID handling issues.

petercat-assistant[bot]
petercat-assistant bot reviewed Nov 12, 2024
View reviewed changes
server/github_app/router.py
@@ -76,9 +76,9 @@ def github_app_callback(code: str, installation_id: str, setup_action: str):
)
for repo in installed_repositories["repositories"]:
repository_config = RepositoryConfig(
owner_id=repo["owner"]["id"],
owner_id=str(repo["owner"]["id"]),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converting owner_id to a string ensures consistent handling of IDs, which can prevent potential issues if the ID is expected to be a string elsewhere in the code.

petercat-assistant[bot]
petercat-assistant bot reviewed Nov 12, 2024
View reviewed changes
server/github_app/router.py
repo_name=repo["full_name"],
repo_id=repo["id"],
repo_id=str(repo["id"]),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converting repo_id to a string ensures consistent handling of IDs, which can prevent potential issues if the ID is expected to be a string elsewhere in the code.

@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
server/github_app/router.py 36.36% <ø> (+0.40%) ⬆️

... and 1 file with indirect coverage changes

xingwanying
xingwanying approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@xingwanying xingwanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@xingwanying xingwanying merged commit 6e3c732 into main Nov 12, 2024
5 checks passed
@xingwanying xingwanying deleted the 1030 branch November 12, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petercat-assistant petercat-assistant[bot] petercat-assistant[bot] left review comments

@xingwanying xingwanying xingwanying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

app install failed
2 participants
@ch-liuzhide @xingwanying