Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default pull request events to the branch HEAD commit #21

Merged
merged 5 commits into from
Jun 19, 2020

Conversation

peter-evans
Copy link
Owner

@peter-evans peter-evans commented Jun 19, 2020

Fixes #20

@peter-evans peter-evans changed the title head_sha Default pull request events to the branch HEAD commit Jun 19, 2020
@@ -31,13 +31,6 @@ jobs:
with:
name: action.yml
path: action.yml
- id: vars
run: |
if [[ "${{ github.event_name }}" == "pull_request" ]]; then \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great if this can be avoided in all workflows where you’d want to support both branch pushes and PRs.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. It was a bit of an oversight that I didn't add this into the action earlier. Thanks for raising the issue!

@peter-evans peter-evans merged commit db40cd9 into master Jun 19, 2020
@peter-evans peter-evans deleted the pr-comment branch June 19, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation update: Use head_ref for comments on PR commits?
2 participants