Merge pull request #37 from Phil-Friderici/puppet-lint

Satisfy puppet-lint

manifests/files.pp

@@ -44,7 +44,6 @@
 {
   # Parameter validation
   validate_re($ensure, ['^absent$', '^present$'], "Invalid ensure: ${ensure} - (Must be 'present' or 'absent')")
-  validate_re($cmd, ['^dd$', '^fallocate$'], "Invalid cmd: ${cmd} - (Must be 'dd' or 'fallocate')")
   validate_string($swapfile)
   $swapfilesize_mb = to_bytes($swapfilesize) / 1000000
   validate_bool($add_mount)
@@ -61,6 +60,9 @@
       'fallocate': {
         Exec["Create swap file ${swapfile}"] { command => "/usr/bin/fallocate -l ${swapfilesize_mb}M ${swapfile}" }
       }
+      default: {
+        fail("Invalid cmd: ${cmd} - (Must be 'dd' or 'fallocate')")
+      }
     }
     file { $swapfile:
       owner   => root,

spec/defines/files_spec.rb

@@ -121,4 +121,15 @@
         )
     end
   end
+
+  context 'with cmd set to invalid value' do
+    let(:params) do
+      {
+        :cmd => 'invalid',
+      }
+    end
+    it 'should fail' do
+      expect { should contain_class(subject) }.to raise_error(Puppet::Error, /Invalid cmd: invalid - \(Must be \'dd\' or \'fallocate\'\)/)
+    end
+  end
 end