Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase performance by checking for @jsx comment before compiling. #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

niondir
Copy link

@niondir niondir commented Oct 19, 2014

It saves me some seconds if I only pass files with the @jsx header to React.transform. All other files have no need to be transformed.

@zertosh
Copy link

zertosh commented Oct 21, 2014

@niondir: /** @jsx React.DOM */ is going away in React 0.12 http://facebook.github.io/react/blog/2014/10/16/react-v0.12-rc1.html#the-jsx-pragma-is-gone

@niondir
Copy link
Author

niondir commented Oct 24, 2014

Good point. A better solution for may problem would be to defined include/exclude paths from where files are pares. Currently it's filtered only based on the extension.
I wan't at least exclude all node_module dirs. Or include only one subdirectory of my project like "/public".

@mweibel
Copy link

mweibel commented Jan 4, 2015

👍 a PR might be the wrong place to discuss this, but I just had an issue with this. node-jsx injecting itself into the default .js extension loader will lead to a massive memory usage increase. I switched now to .jsx and renamed all JSX files, memory usage went from ~300MB down to ~40MB.
I think there should be at least a warning in the README to prevent everyone from doing the same mistake.

@niondir
Copy link
Author

niondir commented Jan 7, 2015

Yep, it's not only the memory usage but also the startup time. Checking for the extension is probably the best way to solve the problem. That's what I do now, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants