[ML] Accessibility fix for structural markup on table rows (elastic#5…

…5075) * [ML] Accessibility fix for structural markup on table rows * [ML] Fix type error on Transforms table cell for scope property
peteharverson · Jan 17, 2020 · e9a902a · e9a902a
1 parent 7f04faf
commit e9a902a
Show file tree

Hide file tree

Showing 14 changed files with 16 additions and 0 deletions.
diff --git a/...ion/components/annotations/annotations_table/__snapshots__/annotations_table.test.js.snap b/...ion/components/annotations/annotations_table/__snapshots__/annotations_table.test.js.snap
diff --git a/...ugins/ml/public/application/components/annotations/annotations_table/annotations_table.js b/...ugins/ml/public/application/components/annotations/annotations_table/annotations_table.js
@@ -323,6 +323,7 @@ const AnnotationsTable = injectI18n(
           }),
           sortable: true,
           width: '50%',
+          scope: 'row',
         },
         {
           field: 'timestamp',

diff --git a/...egacy/plugins/ml/public/application/components/anomalies_table/anomalies_table_columns.js b/...egacy/plugins/ml/public/application/components/anomalies_table/anomalies_table_columns.js
@@ -101,6 +101,7 @@ export function getColumns(
         defaultMessage: 'time',
       }),
       dataType: 'date',
+      scope: 'row',
       render: date => renderTime(date, interval),
       textOnly: true,
       sortable: true,

diff --git a/x-pack/legacy/plugins/ml/public/application/components/ml_in_memory_table/types.ts b/x-pack/legacy/plugins/ml/public/application/components/ml_in_memory_table/types.ts
@@ -28,6 +28,7 @@ export interface FieldDataColumnType<T> {
   render?: RenderFunc;
   footer?: string | ReactElement | FooterFunc;
   textOnly?: boolean;
+  scope?: 'col' | 'row' | 'colgroup' | 'rowgroup';
   'data-test-subj'?: string;
 }
 

diff --git a/...ion/data_frame_analytics/pages/analytics_management/components/analytics_list/columns.tsx b/...ion/data_frame_analytics/pages/analytics_management/components/analytics_list/columns.tsx
@@ -182,6 +182,7 @@ export const getColumns = (
       sortable: true,
       truncateText: true,
       'data-test-subj': 'mlAnalyticsTableColumnId',
+      scope: 'row',
     },
     {
       field: DataFrameAnalyticsListColumn.description,

diff --git a/...blic/application/jobs/jobs_list/components/job_details/forecasts_table/forecasts_table.js b/...blic/application/jobs/jobs_list/components/job_details/forecasts_table/forecasts_table.js
@@ -204,6 +204,7 @@ class ForecastsTableUI extends Component {
         render: date => formatDate(date, TIME_FORMAT),
         textOnly: true,
         sortable: true,
+        scope: 'row',
       },
       {
         field: 'forecast_start_timestamp',

diff --git a/x-pack/legacy/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js b/x-pack/legacy/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js
@@ -172,6 +172,7 @@ class JobsListUI extends Component {
         sortable: true,
         truncateText: false,
         width: '20%',
+        scope: 'row',
         render: isManagementTable ? id => this.getJobIdLink(id) : undefined,
       },
       {

diff --git a/.../application/settings/calendars/edit/events_table/__snapshots__/events_table.test.js.snap b/.../application/settings/calendars/edit/events_table/__snapshots__/events_table.test.js.snap
diff --git a/...legacy/plugins/ml/public/application/settings/calendars/edit/events_table/events_table.js b/...legacy/plugins/ml/public/application/settings/calendars/edit/events_table/events_table.js
@@ -63,6 +63,7 @@ export const EventsTable = injectI18n(function EventsTable({
       }),
       sortable: true,
       truncateText: true,
+      scope: 'row',
     },
     {
       field: 'start_time',

diff --git a/...gins/ml/public/application/settings/calendars/list/table/__snapshots__/table.test.js.snap b/...gins/ml/public/application/settings/calendars/list/table/__snapshots__/table.test.js.snap
diff --git a/x-pack/legacy/plugins/ml/public/application/settings/calendars/list/table/table.js b/x-pack/legacy/plugins/ml/public/application/settings/calendars/list/table/table.js
@@ -43,6 +43,7 @@ export const CalendarsListTable = injectI18n(function CalendarsListTable({
       }),
       sortable: true,
       truncateText: true,
+      scope: 'row',
       render: id => <EuiLink href={`#/settings/calendars_list/edit_calendar/${id}`}>{id}</EuiLink>,
     },
     {

diff --git a/...plugins/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap b/...plugins/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap
diff --git a/x-pack/legacy/plugins/ml/public/application/settings/filter_lists/list/table.js b/x-pack/legacy/plugins/ml/public/application/settings/filter_lists/list/table.js
@@ -85,6 +85,7 @@ function getColumns() {
       }),
       render: id => <EuiLink href={`#/settings/filter_lists/edit_filter_list/${id}`}>{id}</EuiLink>,
       sortable: true,
+      scope: 'row',
     },
     {
       field: 'description',

diff --git a/.../transform/public/app/sections/transform_management/components/transform_list/columns.tsx b/.../transform/public/app/sections/transform_management/components/transform_list/columns.tsx
@@ -138,6 +138,7 @@ export const getColumns = (
       name: 'ID',
       sortable: true,
       truncateText: true,
+      scope: 'row',
     },
     {
       field: TRANSFORM_LIST_COLUMN.DESCRIPTION,