[ML] Fix lat_long anomalies table links menu and value formatting (el…

…astic#50916)
peteharverson · Nov 18, 2019 · 78da9c2 · 78da9c2
1 parent bf75969
commit 78da9c2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/x-pack/legacy/plugins/ml/public/components/anomalies_table/anomalies_table_columns.js b/x-pack/legacy/plugins/ml/public/components/anomalies_table/anomalies_table_columns.js
@@ -48,10 +48,10 @@ function renderTime(date, aggregationInterval) {
   }
 }
 
-function showLinksMenuForItem(item) {
-  const canConfigureRules = (isRuleSupported(item) && checkPermission('canUpdateJob'));
+function showLinksMenuForItem(item, showViewSeriesLink) {
+  const canConfigureRules = (isRuleSupported(item.source) && checkPermission('canUpdateJob'));
   return (canConfigureRules ||
-    item.isTimeSeriesViewRecord ||
+    (showViewSeriesLink && item.isTimeSeriesViewRecord) ||
     item.entityName === 'mlcategory' ||
     item.customUrls !== undefined);
 }
@@ -248,7 +248,7 @@ export function getColumns(
     });
   }
 
-  const showLinks = (showViewSeriesLink === true) || items.some(item => showLinksMenuForItem(item));
+  const showLinks = items.some(item => showLinksMenuForItem(item, showViewSeriesLink));
 
   if (showLinks === true) {
     columns.push({

diff --git a/x-pack/legacy/plugins/ml/public/components/anomalies_table/description_cell.js b/x-pack/legacy/plugins/ml/public/components/anomalies_table/description_cell.js
@@ -29,7 +29,7 @@ export function DescriptionCell({ actual, typical }) {
   } = getMetricChangeDescription(actual, typical);
 
   return (
-    <EuiFlexGroup gutterSize="s">
+    <EuiFlexGroup gutterSize="s" alignItems="center">
       {iconType !== undefined &&
         <EuiFlexItem grow={false}>
           <EuiIcon

diff --git a/x-pack/legacy/plugins/ml/public/formatters/format_value.js b/x-pack/legacy/plugins/ml/public/formatters/format_value.js
@@ -37,8 +37,10 @@ export function formatValue(value, mlFunction, fieldFormat, record) {
     if (value.length === 1) {
       return formatSingleValue(value[0], mlFunction, fieldFormat, record);
     } else {
-      // Return with array style formatting.
-      const values = value.map(val => formatSingleValue(val, mlFunction, fieldFormat, record));
+      // Currently only multi-value response is for lat_long detectors.
+      // Return with array style formatting, with items formatted as numbers, rather than
+      // the default String format which is set for geo_point and geo_shape fields.
+      const values = value.map(val => formatSingleValue(val, mlFunction, undefined, record));
       return `[${values}]`;
     }
   } else {