.with should convert value up front

tc39/proposal-change-array-by-copy#86
petamoriken · Jun 26, 2022 · 6635294 · 6635294
1 parent 7a0865b
commit 6635294
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/src/Float16Array.mjs b/src/Float16Array.mjs
@@ -82,6 +82,7 @@ import {
   SpeciesConstructor,
   ToIntegerOrInfinity,
   ToLength,
+  ToNumber,
   defaultCompare,
 } from "./_util/spec.mjs";
 
@@ -537,6 +538,8 @@ export class Float16Array {
     const relativeIndex = ToIntegerOrInfinity(index);
     const k = relativeIndex >= 0 ? relativeIndex : length + relativeIndex;
 
+    const number = ToNumber(value);
+
     if (k < 0 || k >= length) {
       throw new NativeRangeError(OFFSET_IS_OUT_OF_BOUNDS);
     }
@@ -554,7 +557,7 @@ export class Float16Array {
     );
     const array = getFloat16BitsArray(cloned);
 
-    array[k] = roundToFloat16Bits(value);
+    array[k] = roundToFloat16Bits(number);
 
     return cloned;
   }

diff --git a/src/_util/spec.mjs b/src/_util/spec.mjs
@@ -17,16 +17,25 @@ import {
 const MAX_SAFE_INTEGER = NativeNumber.MAX_SAFE_INTEGER;
 
 /**
- * @see https://tc39.es/ecma262/#sec-tointegerorinfinity
+ * @see https://tc39.es/ecma262/#sec-tonumber
  * @param {unknown} target
  * @returns {number}
  */
-export function ToIntegerOrInfinity(target) {
+export function ToNumber(target) {
   if (typeof target === "bigint") {
     throw NativeTypeError(CANNOT_CONVERT_A_BIGINT_VALUE_TO_A_NUMBER);
   }
 
-  const number = NativeNumber(target);
+  return NativeNumber(target);
+}
+
+/**
+ * @see https://tc39.es/ecma262/#sec-tointegerorinfinity
+ * @param {unknown} target
+ * @returns {number}
+ */
+export function ToIntegerOrInfinity(target) {
+  const number = ToNumber(target);
 
   if (NumberIsNaN(number) || number === 0) {
     return 0;