Starting model

[alagane]

This is the first class diagram, with relations between classes. Multiplicities in classes are only for max 1 and max * (respectively reference and List).
Each class has getter and setter for each of its attributes.

[cdeneux]

• Don't forget to use modifier final when it is needed,
• Can you add description of model as javadoc ?

[alagane]

I changed some things in the model, like using maps directly for component parameters and placeholders, thus I removed the description of placeholders.
I used final for setters parameters.
I added Javadoc.

[cdeneux]

Minor stuff in POM file

[cdeneux]

Great job !!

Don't forget to use the modifier final on method parameters, class members and variables.

Remove binary files in directory src/main/resources.

ZIP files in src/test/resources should be smaller as possible. I think that your tests should be ok if they contain only the file jbi.xml.

[vincent-zurczak]

Good work indeed.
But you can make your code more compact, more efficient and easier to understand. You also need to homogenize javadoc and line breaks. Also, think about separating beans and utilities in different packages.

[cdeneux]

• Mettre le champ @author de la javadoc en toutes lettres avec le nom de la société: Alexandre LAGANE - Linagora.
• Ne pas oublier l'usage du modifier final sur les arguments de méthodes, les définitions de variables et les attributs de classes.
• Dans les modèles XSD, utiliser minOccurs="1" plutôt que de ne pas le mettre. Ca evite la confusion à la lecture au cas où le lecteur ne connait pas le comportement par défaut.

[cdeneux]

-- Erreur de localistation pour cette review, à supprimer ou acquitter. Je ne peux pas le faire --

[alagane]

Close to make a clean new one