Fix HealthCheck.Persistence littering journal and snapshot store #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Mar 8, 2023
| } | ||
| else | ||
| { | ||
| Context.System.Scheduler.ScheduleTellOnce(_delay, _probe, "hit" + _probeCounter++, Self); |
There was a problem hiding this comment.
why don't we version this any longer?
There was a problem hiding this comment.
I don't see the merit of versioning this, we already have "versioning" via the sequence number
There was a problem hiding this comment.
Chesterton's Fence - why remove it if it's not hurting anything? I can't tell you, given how old the code is, why it was there in the first place.
|
How does this fix the problem? I'm not following |
| { | ||
| _probe = Context.ActorOf(Props.Create(() => new SuicideProbe(Self, firstTime, _id))); | ||
| if(firstTime) | ||
| var isEven = _probeCounter % 2 == 0; |
There was a problem hiding this comment.
Need to add comments explaining the process here. Not obvious just from reading the code.
| @@ -238,8 +252,8 @@ public SuicideProbe(IActorRef probe, bool firstAttempt, string id) | |||
|
|
|||
| if (!_firstAttempt) | |||
| { | |||
| DeleteMessages(save.Metadata.SequenceNr - 1); | |||
| DeleteSnapshots(new SnapshotSelectionCriteria(save.Metadata.SequenceNr - 1)); | |||
| DeleteMessages(long.MaxValue); | |||
There was a problem hiding this comment.
Need to detail these changes with comments too
Aaronontheweb
requested changes
Mar 8, 2023
| { | ||
| _probe.Tell("hit" + _probeCounter++); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.