Re-add chunked transaction batching support #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Sep 27, 2022
|
|
||
| var entities = await _tableClient.QueryAsync<TableEntity>("PartitionKey eq 'test'", null, null, cts.Token) | ||
| .ToListAsync(cts.Token); | ||
| entities.Count.Should().Be(0); |
|
|
||
| var entities = await _tableClient.QueryAsync<TableEntity>("PartitionKey eq 'test'", null, null, cts.Token) | ||
| .ToListAsync(cts.Token); | ||
| entities.Count.Should().Be(50); |
|
|
||
| using var cts = new CancellationTokenSource(3.Seconds()); | ||
| var result = await _tableClient.ExecuteBatchAsLimitedBatches(entries, cts.Token); | ||
| result.Count.Should().Be(505); |
| @@ -365,10 +370,10 @@ protected override async Task<IImmutableList<Exception>> WriteMessagesAsync(IEnu | |||
| if (_log.IsDebugEnabled && _settings.VerboseLogging) | |||
| _log.Debug("Attempting to write batch of {0} messages to Azure storage", batchItems.Count); | |||
|
|
|||
| var response = await Table.SubmitTransactionAsync(batchItems, _shutdownCts.Token); | |||
| var response = await Table.ExecuteBatchAsLimitedBatches(batchItems, _shutdownCts.Token); | |||
There was a problem hiding this comment.
Need to explain somewhere why we call this method and what the historical reasons were, that we we don't accidentally remove this method again in the future. i.e. this is an Azure Table Storage API limitation we're working around and we know this breaks atomicity for batches over 100 but we can't do anything about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
Re-add transaction batching code.
NOTE
This means that on a very high load system, atomic writes are NOT atomic anymore. Since transactions have to be chunked to 100 entries, partial writes can happen if an exception was thrown mid-write.