Problem with implimentation of akka persistence contract #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Apr 3, 2021
| @@ -383,15 +383,19 @@ protected override void PreStart() | |||
| if (_log.IsDebugEnabled && _settings.VerboseLogging) | |||
| foreach (var r in persistenceResults) | |||
| _log.Debug("Azure table storage wrote entity [{0}] with status code [{1}]", r.Etag, r.HttpStatusCode); | |||
|
|
|||
| exceptions = exceptions.Add(null); | |||
There was a problem hiding this comment.
This looks correct - we do the same thing in Akka.Persistence.SqlServer:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran in to a issue where if at least one AtomicWrite failed while at least one succeeded then the persistence actor would fail (instead of replying with a rejected message). This seem to be because of the following validation:
https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka.Persistence/Journal/AsyncWriteJournal.cs#L393.
This PR should implement the contract correctly to get the expected response.