Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a retry-backoff logic to snapshot blob storage initialization #126

Conversation

Arkatufus
Copy link
Contributor

No description provided.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus that n-1 bug - which I'll patch in a subsequent PR

@@ -24,6 +24,17 @@ namespace Akka.Persistence.Azure.Snapshot
/// </summary>
public class AzureBlobSnapshotStore : SnapshotStore
{
private static readonly Dictionary<int, TimeSpan> RetryInterval =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - exponential backoff table...

catch (Exception ex)
{
retry--;
if (retry < 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be retry == 0 - otherwise your dictionary accessor attempt will fail with a MissingKeyException below`

@Aaronontheweb Aaronontheweb merged commit 16a9da9 into petabridge:dev Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants