Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow private access on snapshot container #144

Closed
MattiasJakobsson opened this issue Feb 2, 2021 · 4 comments
Closed

Allow private access on snapshot container #144

MattiasJakobsson opened this issue Feb 2, 2021 · 4 comments
Milestone

Comments

@MattiasJakobsson
Copy link
Contributor

At the moment the access on the snapshot container is hard coded to public (https://github.com/petabridge/Akka.Persistence.Azure/blob/dev/src/Akka.Persistence.Azure/Snapshot/AzureBlobSnapshotStore.cs#L73). We would like to set the access to private in our case, so it would be nice to have a setting for this.

We're also creating the container and table from outside of our application, so it would be nice to have a setting to disable the container creation (something like this maybe: https://github.com/akkadotnet/akka.net/blob/dev/src/contrib/persistence/Akka.Persistence.Sqlite/sqlite.conf#L29).

I'd happily make the changes required and open a PR. I'd just like to get the maintainers thoughts first.

@davidhagg
Copy link

Any comments about this issue? We're doing a security review and this is an open issue for us. We're happy to do a PR.

@Aaronontheweb Aaronontheweb added this to the v0.8.0 milestone Apr 9, 2021
@Aaronontheweb
Copy link
Member

At the moment the access on the snapshot container is hard coded to public (https://github.com/petabridge/Akka.Persistence.Azure/blob/dev/src/Akka.Persistence.Azure/Snapshot/AzureBlobSnapshotStore.cs#L73). We would like to set the access to private in our case, so it would be nice to have a setting for this.

Yes, we should absolutely do that.

@Arkatufus
Copy link
Contributor

The PR #150 only addressed half of the issue. Still need a configuration to change container public access level.

@MattiasJakobsson
Copy link
Contributor Author

You're right @Arkatufus, I just fixed our case in #150. I've opened a another pr (#152) to handle public access level as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants