#413 quotations added for paths which include spaces #424
Conversation
| goto :eof | ||
|
|
||
| :help | ||
| powershell -NoProfile -ExecutionPolicy Bypass -Command ^ | ||
| "$psakeDir = ([array](dir %~dp0Vendor\packages\psake.*))[-1]; .$psakeDir\tools\psake.ps1 build.psake.ps1 -docs -ScriptPath $psakeDir\tools" | ||
| @SET cmd=$psakeDir = ([array](dir """%~dp0vendor\packages\psake.*"""))[-1]; ".$psakeDir\tools\psake.ps1 build.psake.ps1" -docs -ScriptPath "$psakeDir\tools" |
There was a problem hiding this comment.
I'm a little confused by the extra quotation marks around the argument to the dir command in this line (and the same on line 9). Are they necessary? Quick test seemed to work fine with just a single pair of quotes.
It's also not necessary to put the quotation marks around the PowerShell tokens such as $psakeDir, because they don't get expanded until after they're passed to a command, and spaces in those values don't matter. (But they also don't hurt anything, so I'm fine with that part either way.)
|
@dlwyatt Any more comments on this, can it be merged? Or you'd prefer if the extra quotes were removed? |
|
Just want to understand why they're there. The code would be a bit easier to read without a bunch of extra punctuation if it's not necessary. |
#413 quotations added for paths which include spaces
No description provided.