Mock fix #362
Merged
Mock fix #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two bugs here. One, if a mock exists but no blocks match their parameter filter, the original command is called from Pester's session state instead of from the session state of the original caller of the mock. This can sometimes cause bugs in people's scripts. Second, inside of Mock / Validate-Command, calls are being made to Get-Content in such a way that if the test author mocks it, Pester's internals wind up triggering the mock (because it runs code in their module scope.) This can also lead to errors.
There's still a potential gotcha here if a non-advanced function is mocked, and there are no matching parameter filters. In that case, there's no $PSCmdlet variable in the mock bootstrap function, and I don't know how else to find the caller's SessionState object. In that circumstance, I opted to execute the original command from the scope where the mock is defined, which should be correct most of the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tests and bug fixes to address #361 .