Initial fix for #286 #323
Merged
Initial fix for #286 #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works, but there might be some weirdness that can still happen if you mock a global function in conjunction with -ModuleName or InModuleScope. (The global function gets renamed for the duration of the mock, but the mock is only available from that single module. You can't mock the same global function from two different modules at once.) Not sure if it's worth worrying about that edge case, since this "mocking global functions" scenario is already pretty rare to begin with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works, but there might be some weirdness that can still happen if you mock a global function in conjunction with -ModuleName or InModuleScope. (The global function gets renamed for the duration of the mock, but the mock is only available from that single module. You can't mock the same global function from two different modules at once.)
Not sure if it's worth worrying about that edge case, since this "mocking global functions" scenario is already pretty rare to begin with.
Creating the PR to start discussion on this fix.